View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000100JVT JM H.264/AVC reference softwareencoderpublic2008-02-21 13:122008-02-22 03:12
Reporterauberon Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status feedbackResolutionopen 
Product VersionJM 12.0 
Summary0000100: variable was not used correctly
Descriptionfilename:md_highfast.c
function:encode_one_macroblock_highfast
line:222
statement:index--
Here I think it should be k--, or k=0 because index is not assigned to valid value before.
TagsNo tags attached.

Activities

Karsten Suehring

2008-02-21 18:02

administrator   ~0000173

Can you double-check with the current JM 13.2? The only "index--" statement I could find there is located on ln. 417 and seem OK there.

auberon

2008-02-22 03:12

reporter   ~0000174

In JM13.2, it has been removed from the for loop. (from line199)

 for (ctr16x16=0, k=0; k<1; k++)
          {
            i16mode = 0;

            //--- for INTER16x16 check all prediction directions ---
            if (bslice)
            {
              best8x8pdir[1][0] = best8x8pdir[1][1] = best8x8pdir[1][2] = best8x8pdir[1][3] = ctr16x16;

              if ( (bslice) && (input->BiPredMotionEstimation)
                && (ctr16x16 == 2 && img->bi_pred_me[mode] < 2 && mode == 1))
                ctr16x16--;
              ctr16x16++;
            }

            currMB->c_ipred_mode=DC_PRED_8;
            compute_mode_RD_cost(mode, currMB, enc_mb, &min_rdcost, &min_dcost, &min_rate, i16mode, bslice, &inter_skip);

            if ((input->BiPredMotionEstimation) && (bslice) && ctr16x16 == 2
              && img->bi_pred_me[mode] < 2 && mode == 1 && best8x8pdir[1][0] == 2)
              img->bi_pred_me[mode] = img->bi_pred_me[mode] + 1;
          } // for (ctr16x16=0, k=0; k<1; k++)
I think in if(){},we also need modify variable k in order to deal with bslice.

Issue History

Date Modified Username Field Change
2008-02-21 13:12 auberon New Issue
2008-02-21 18:02 Karsten Suehring Note Added: 0000173
2008-02-21 18:02 Karsten Suehring Status new => feedback
2008-02-22 03:12 auberon Note Added: 0000174