View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000217 | JVT JM H.264/AVC reference software | decoder | public | 2010-07-01 06:20 | 2011-04-05 18:06 |
| Reporter | Dzung Hoang | Assigned To | Karsten Suehring | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | JM 17.1 | ||||
| Fixed in Version | JM 18.0 | ||||
| Summary | 0000217: default configuration parameters are ignored in some cases | ||||
| Description | In the ParseCommand() routine, InitParams(Map) is called to initialize the global cfgparams. But the initialized cfgparams is overwritten if there is no configuration file specified on the command line or if decoder.cfg is not present. | ||||
| Additional Information | Change //Set default parameters. printf ("Setting Default Parameters...\n"); InitParams(Map); to //Set default parameters. printf ("Setting Default Parameters...\n"); InitParams(Map); memcpy(p_Inp, &cfgparams, sizeof(InputParameters)); | ||||
| Tags | No tags attached. | ||||
|
|
Decoder seems to set several parameters of p_Inp inside Configure() as well before it reaches at this point. Doing the above (or *p_Inp = cfgparams) wouldn't be good since you may override those. Maybe the better method would be to first set cfgparams = *p_Inp instead of setting it to zero, followed by performing InitParams(Map), and then finally copy cfgparams back to *p_Inp. That way the initial set values will not be lost. |
|
|
I'm seeing the fix that Alexis is describing below in the dev branch. I think the whole parameter reading would need some work (i.e. removing duplicate initializations). Closing this issue for now. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-07-01 06:20 | Dzung Hoang | New Issue | |
| 2010-07-09 07:36 | Alexis Michael Tourapis | Note Added: 0000377 | |
| 2011-04-05 18:06 | Karsten Suehring | Note Added: 0000423 | |
| 2011-04-05 18:06 | Karsten Suehring | Status | new => resolved |
| 2011-04-05 18:06 | Karsten Suehring | Fixed in Version | => JM 18.0 |
| 2011-04-05 18:06 | Karsten Suehring | Resolution | open => fixed |
| 2011-04-05 18:06 | Karsten Suehring | Assigned To | => Karsten Suehring |
