View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000224 | JVT JM H.264/AVC reference software | decoder | public | 2010-07-08 17:42 | 2011-11-10 16:30 |
| Reporter | alanyan | Assigned To | Yuwen He | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | JM 17.1 | ||||
| Fixed in Version | JM 18.1 | ||||
| Summary | 0000224: "ref_pic" is wrong in dpb_split_field() when multi-slice is used | ||||
| Description | In mbuffer.c, line 7174, 4179, 4187, 4192, 4227, 4235. In the code, "p_Vid->ppSliceList[0]->listX" is used as a common Look-Up-Table for all slices's ref_idx. I believe different slice can have a different listx. I recommand adding a "slice_pos" in PicMotionParams. Then simply adding code of "mv_info->slice_pos = current_slice_nr" in reset_mv_info() and then change "p_Vid->ppSliceList[0]->listX" to "p_Vid->ppSliceList[mv_info->slice_pos]->listX" will be ok. | ||||
| Tags | No tags attached. | ||||
|
|
Although I agree that this is wrong, I disagree somehow with the solution. The code should instead be using directly the frame or field ref_pic and ignore the ref_idx. ref_pic is basically a pointer that allows you to then access directly the appropriate field or frame structure. That saves memory and avoids other unecessary indexing that the current code seems to be doing. |
|
|
I agree your solution is simpler. |
|
|
I think we fixed this for the decoder with resolving issue 0000283. The encoder does not support different reference picture lists in different slices, so the code should be safe. I think it would still be desirable to keep encoder and decoder designs aligned, but that's not a high priority issue. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-07-08 17:42 | alanyan | New Issue | |
| 2010-07-09 06:51 | Alexis Michael Tourapis | Note Added: 0000374 | |
| 2010-07-09 06:51 | Alexis Michael Tourapis | Status | new => assigned |
| 2010-07-09 06:51 | Alexis Michael Tourapis | Assigned To | => Yuwen He |
| 2010-07-09 07:28 | alanyan | Note Added: 0000376 | |
| 2011-11-10 16:22 | Karsten Suehring | Relationship added | has duplicate 0000283 |
| 2011-11-10 16:30 | Karsten Suehring | Note Added: 0000513 | |
| 2011-11-10 16:30 | Karsten Suehring | Status | assigned => resolved |
| 2011-11-10 16:30 | Karsten Suehring | Fixed in Version | => JM 18.1 |
| 2011-11-10 16:30 | Karsten Suehring | Resolution | open => fixed |
