View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000025 | JVT JM H.264/AVC reference software | decoder | public | 2006-11-30 10:38 | 2007-01-11 18:50 |
| Reporter | Zhou Ya | Assigned To | Karsten Suehring | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | JM 11.0 | ||||
| Fixed in Version | JM 12.0 | ||||
| Summary | 0000025: wrong initialized value for "threshold" in function "ercCollect8PredBlocks" in file "erc_do_i.c" | ||||
| Description | I think the initialized value for "threshold" should be ERC_BLOCK_OK. Otherwise,there is no need to use "do{}while()" because the "if (threshold < ERC_BLOCK_CONCEALED) break;"will be enabled after do the iteration once. | ||||
| Tags | No tags attached. | ||||
|
|
I think it's not such a trivial change. I actually don't know the original intention, but it might sometimes be better to conceal from more blocks than only these which were originally decoded. |
|
|
After reading VCEG-N62 again, I think the original intention was to use concealed neighbors only if there are less than two decoded neighbors. Please re-open, if this intention was changed later. |
|
|
Zhou, did you run tests with the different settings? Can you post any visual test results? |
|
|
My quick visual testing shows improvements for small regular (non FMO) slices with foreman and mobile. So I would vote for ERC_BLOCK_OK |
|
|
closing the issued since there were no additional comments |
|
|
ups, status should be resolved |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2006-11-30 10:38 | Zhou Ya | New Issue | |
| 2006-12-20 14:50 | Karsten Suehring | Status | new => assigned |
| 2006-12-20 14:50 | Karsten Suehring | Assigned To | => Karsten Suehring |
| 2006-12-20 14:54 | Karsten Suehring | Note Added: 0000037 | |
| 2006-12-20 14:54 | Karsten Suehring | Status | assigned => acknowledged |
| 2006-12-20 14:55 | Karsten Suehring | Severity | trivial => minor |
| 2006-12-20 15:17 | Karsten Suehring | Status | acknowledged => resolved |
| 2006-12-20 15:17 | Karsten Suehring | Fixed in Version | => JM 11.0-devel |
| 2006-12-20 15:17 | Karsten Suehring | Resolution | open => fixed |
| 2006-12-20 15:17 | Karsten Suehring | Note Added: 0000038 | |
| 2006-12-20 18:58 | Karsten Suehring | Status | resolved => feedback |
| 2006-12-20 18:58 | Karsten Suehring | Resolution | fixed => reopened |
| 2006-12-20 18:58 | Karsten Suehring | Note Added: 0000039 | |
| 2006-12-20 20:04 | Karsten Suehring | Note Added: 0000040 | |
| 2007-01-11 18:49 | Karsten Suehring | Status | feedback => closed |
| 2007-01-11 18:49 | Karsten Suehring | Note Added: 0000042 | |
| 2007-01-11 18:49 | Karsten Suehring | Resolution | reopened => fixed |
| 2007-01-11 18:50 | Karsten Suehring | Status | closed => resolved |
| 2007-01-11 18:50 | Karsten Suehring | Note Added: 0000043 |
